Repository navigation
style(css): clippy 1.99 failed the workspace on a range loop in mix2 - #117
Merged
jamesconwaydev merged 1 commit intoNov 19, 2026
Conversation
jamesconwaydev
approved these changes
Nov 19, 2026
jamesconwaydev
left a comment
Collaborator
There was a problem hiding this comment.
Good catch before CI's stable moved. Thanks.
jamesconwaydev
enabled auto-merge (squash)
November 19, 2026 20:26
needless_range_loop flags mix2's for i in 0..3, which indexes out. CI installs stable, so its clippy job fails once the runner has 1.99. Loop over out with iter_mut().enumerate(); i still indexes the two colours' channels and the hue check.
foothillsdigital
force-pushed
the
fix/clippy-needless-range-loop
branch
from
November 19, 2026 20:42
abde48f to
af37ca4
Compare
Collaborator
Author
|
Rebased onto main (af37ca4), since |
jamesconwaydev
approved these changes
Nov 19, 2026
jamesconwaydev
left a comment
Collaborator
There was a problem hiding this comment.
Same two lines, still good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Under Rust 1.99's clippy,
cargo clippy --workspace --all-targets -- -D warningsfails on main, inparsec-css:CI installs
toolchain: stablewith no pinned version, so its clippy job fails as soon as the runner picks up 1.99. I mentioned this on #115.Change
mix2loops overoutwithiter_mut().enumerate()and writes*slot.istill indexes both colours' channels and the hue check, as before. The behaviour is identical.Tests
cargo clippy --workspace --all-targets -- -D warningswith Rust 1.99.1: fails on main, clean here.cargo fmt --checkis clean.cargo test --release -p parsec-html-csspasses (92 tests, 0 failed), including the colour-mixing tests that run throughmix2.Checklist
cargo fmt,cargo clippy -- -D warningsandcargo testpass locallycrates/parsec/src, its tests, examples, scripts or fuzz targets were made in Netweir first (none: this isparsec-css)