Potential fix for code scanning alert no. 27: Workflow does not contain permissions#553
Merged
daveshanley merged 1 commit intomainfrom Mar 29, 2026
Merged
Potential fix for code scanning alert no. 27: Workflow does not contain permissions#553daveshanley merged 1 commit intomainfrom
daveshanley merged 1 commit intomainfrom
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 236 236
Lines 28037 28037
=======================================
Hits 27930 27930
Misses 65 65
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/pb33f/libopenapi/security/code-scanning/27
In general, the problem is solved by explicitly defining a
permissionsblock either at the workflow root (to apply to all jobs) or per job, and setting the minimal needed scopes (typicallycontents: readfor simple build/test workflows). This prevents the jobs from inheriting potentially broad default permissions such ascontents: write.For this workflow, the simplest and safest fix that preserves existing behavior is to add a workflow‑level
permissionssection right after thename: Buildline. The jobs only need to check out the repository and run Go commands; they do not push commits, modify issues, or manage PRs. The Codecov action uses its ownCODECOV_TOKENsecret and does not require GitHub write permissions. Therefore, settingpermissions: contents: readat the top level is sufficient and minimal. No other code or steps need to be changed.Concretely, edit
.github/workflows/build.yamland insert:between the existing
name: Buildline and theon:block. This applies the restricted permissions to bothbuildWindowsandbuildjobs and directly addresses the CodeQL alert.Suggested fixes powered by Copilot Autofix. Review carefully before merging.