HOTFIX: NEB tangent estimation#180
Open
mo-kap wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When facing a flat energy spaces, i.e. the energies of three adjacent images are equal, the current tangent implementation uses the computation for extrema from [1].
However, in [1] this is only applicable if we are at a strict extreme. For the special case of a flat space, taking the same formula (as was done in the current implementation) leads to tangent becoming the zero vector. Thus, at the normalization an invalid value is encountered and NaNs are returned.
This problem then cascades towards failure of LBFGS since we have NaNs.
Fix
On a flat spot, simply fall back to the original NEB tangent computation, taking the weighted average, where the weights are equal for the tangents on both sides.
References
[1] G. Henkelman and H. Jónsson, “Improved tangent estimate in the nudged elastic band method for finding minimum energy paths and saddle points,” J. Chem. Phys., vol. 113, no. 22, pp. 9978–9985, Dec. 2000, doi: 10.1063/1.1323224.