Add Equatable and Hashable property retention#1126
Merged
ileitch merged 2 commits intoMay 15, 2026
Merged
Conversation
1620a5c to
fe56f5d
Compare
Contributor
Author
|
@ileitch This is ready for review, please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retain_equatable_propertiesandretain_hashable_propertiesconfiguration options and CLI flags.EquatableorHashable, including inherited protocol conformances.Motivation
Swift can synthesize
EquatableandHashableconformances from stored properties without producing explicit references in index data. That can make properties appear unused even though changing or removing them changes synthesized equality or hashing behavior.This keeps the behavior opt-in, similar to the existing
retain_codable_propertiessetting, so projects can choose the broader retention behavior when synthesized protocol requirements are part of their API surface.Fixes #869.
Fixes #1028.
Related to #721.
Testing
swift test --filter "RetentionTest/testRetains"swift testswiftformat --quiet --strict .swiftlint lint --quiet --strictbazelisk run //bazel/dev:buildifier.checkgit diff --check