Skip to content

fix: give the playwright npm server time to shut down browser children #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanmiguel wants to merge 1 commit into
base: 4.x
Choose a base branch
from
+7 −1
Open

fix: give the playwright npm server time to shut down browser children #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Playwright/Servers/PlaywrightNpmServer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,14 @@ public function start(): void
public function stop(): void
{
if ($this->systemProcess instanceof SystemProcess && $this->isRunning()) {
// The Playwright node server needs time to clean up its browser
// children — especially Chromium in headed mode, which can take
// close to a second to shut down gracefully. With the old 0.1s
// timeout, SIGTERM raced the browser teardown and Symfony would
// escalate to SIGKILL while children were still detaching,
// leaving the parent pest process waiting on zombie file handles.
$this->systemProcess->stop(
timeout: 0.1,
timeout: 2.0,
signal: PHP_OS_FAMILY === 'Windows' ? null : SIGTERM,
);
}
Expand Down