Skip to content

fix: restore CI checks on 5.x - #53

Open
MrPunyapal wants to merge 5 commits into
pestphp:5.xfrom
MrPunyapal:fix/ci-composer-root-version
Open

MrPunyapal wants to merge 5 commits into
pestphp:5.xfrom
MrPunyapal:fix/ci-composer-root-version

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Restore CI on 5.x without changing the supported dependencies or adding mutation behavior.

  • Set Composer's root version and apply the dependency/parallel options already declared in the CI matrix.
  • Use PHP-Parser's getArgs() API after the existing first-class-callable check, and stop parent traversal at non-node values. These fix the two PHPStan errors.
  • Remove the deprecated PHPUnit setting. Keep the three CLI snapshot tests in one file and clear the inherited worker flag so they can run under the parallel suite without sharing the coverage report concurrently. Snapshot contents are unchanged.

For example, #44's CI failed during dependency installation before tests could run.

Validation: all 319 existing tests pass (627 assertions) sequentially and with four workers on Linux with coverage enabled. PHPStan and formatting pass. CI checks both PHP versions and both dependency versions.

@MrPunyapal MrPunyapal changed the title fix: set Composer root version in CI fix: restore CI checks on 5.x Oct 30, 2026
@MrPunyapal
MrPunyapal requested review from a team and nunomaduro October 30, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant