Repository navigation
Select dirty tests with quoted Git paths - #2042
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Description
--dirtymisses test paths that Git quotes in its human-readable status output. It also selects a missing test when a staged modification precedes its deletion in the working tree.Read Git's NUL-delimited porcelain output and strip only the repository prefix reported by Git. Disable rename pairing for this query so its destination can be selected separately. Drop candidate paths that no longer point to a file, including paths that still have staged or conflicted index entries.
The CLI regressions use real Git repositories at the repository root and in nested projects. They cover spaces, Unicode, renames, and deletions. The staged-modification case verifies that strict empty-suite handling matches an ordinary deletion in both serial and parallel runs. A merge conflict fixture verifies that an existing test still runs and that removing it yields an empty selection.
composer testpassed. The targeted tests and regenerated output snapshot also passed with the other pending Pest fixes applied together.