Add support for nullable vector columns#7
Closed
JulianPasquale wants to merge 1 commit intopgvector:masterfrom
Closed
Add support for nullable vector columns#7JulianPasquale wants to merge 1 commit intopgvector:masterfrom
JulianPasquale wants to merge 1 commit intopgvector:masterfrom
Conversation
Member
|
Hi @JulianPasquale, thanks for reporting and the PR! Merged a version of this in the commit above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ankane,
Looks like the gem doesn't handle nil values gracefully. I created this small script to demostrate the issues I found:
I made some changes to support nil values but I'm not sure if this is the correct approach, maybe defining an empty string as default value for vector columns is just enough.
Feel free to close this Pull Request if the solution is not what you'd expect.