Skip to content

T95 dead code - #146

Merged
niden merged 2 commits into
masterfrom
T95-dead-code
Nov 8, 2026
Merged

niden merged 2 commits into
masterfrom
T95-dead-code

Conversation

@niden

@niden niden commented Nov 8, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Remove HistoryController::clearAction() and indexAction(), Phalcon\DebugBar\Version and CodeFragment::getMode(), which nothing used, and make the debug page exceptions implement Phalcon\Debug\Contracts\DebugThrowable.

Thanks

niden added 2 commits November 7, 2026 22:56
Assisted-by: Claude Code
@niden niden added the bug Something isn't working label Nov 8, 2026
@niden niden self-assigned this Nov 8, 2026
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Code Metrics Report

master (06d9e1c) T95-dead-code (44f7e9c) +/-
Coverage 100.0% 100.0% 0.0%
Test Execution Time 4s 4s 0s
Details
  |                     | master (06d9e1c) | T95-dead-code (44f7e9c) | +/-  |
  |---------------------|------------------|-------------------------|------|
  | Coverage            |           100.0% |                  100.0% | 0.0% |
  |   Files             |               87 |                      86 |   -1 |
  |   Lines             |             2187 |                    2181 |   -6 |
- |   Covered           |             2187 |                    2181 |   -6 |
  | Test Execution Time |               4s |                      4s |   0s |

Code coverage of files in pull request scope (100.0% → 100.0%, patch 100.0%)

Files Coverage +/- Patch Coverage Status
src/Debug/Contracts/DebugThrowable.php 0.0% 0.0% - modified
src/Debug/Exceptions/Exception.php 0.0% 0.0% - modified
src/Debug/Exceptions/RuntimeWarning.php 0.0% 0.0% - modified
src/Debug/Report/CodeFragment.php 100.0% 0.0% - modified
src/Debug/ReportBuilder.php 100.0% 0.0% 100.0% modified
src/DebugBar/Controllers/HistoryController.php 100.0% 0.0% - modified
src/DebugBar/History/FilesystemHistory.php 100.0% 0.0% 100.0% modified
src/DebugBar/Version.php 0.0% -100.0% - removed

Reported by octocov

@niden
niden merged commit 5fbd630 into master Nov 8, 2026
24 checks passed
@niden
niden deleted the T95-dead-code branch November 8, 2026 05:03
@niden niden mentioned this pull request Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant