Repository navigation
Conversation
Describe reader configuration, source precedence, prefixes and inheritance for the model table resolution fix in phalcon/cphalcon#17742. Link the annotations guide to the model guide and state the release requirement. Assisted-by: Codex
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the model-table integration of
Sourcefrom phalcon/cphalcon#17742, as requested in its review: phalcon/cphalcon#17742 (comment).The model guide now shows how to select
AttributesReaderbefore using#[Source], explains named and positional arguments, explicit-source precedence, table prefixes, per-class caching, and inheritance. The annotations guide links to that section. The default PHPDoc reader and@Sourceremain unchanged.An availability note explicitly says that this behavior is not in Phalcon 5.23.0 and requires a release containing the framework fix. The framework PR is still under review, so the note avoids presenting unreleased functionality as part of the existing release.
Related: phalcon/cphalcon#17741, phalcon/cphalcon#17742.
Validation:
@mdx-js/mdx.pnpm buildpasses (3001 pages built).pnpm lint:docspasses (3002 files lint clean).accounting_invoices.git diff --checkpasses.Only the two manual pages in
docs-5.23change; generated API pages, routes and earlier versions are untouched.