Skip to content

Rewrite scanner and parser from re2c/lemon to PHP - #125

Merged
Jeckerson merged 1 commit into
1.0.xfrom
move-out-re2c
Nov 1, 2026
Merged

Jeckerson merged 1 commit into
1.0.xfrom
move-out-re2c

Conversation

@Jeckerson

Copy link
Copy Markdown
Member

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

@Jeckerson
Jeckerson requested a review from niden November 1, 2026 10:15
@Jeckerson Jeckerson self-assigned this Nov 1, 2026
@sonarqubecloud

sonarqubecloud Bot commented Nov 1, 2026

Copy link
Copy Markdown

uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # v2
with:
php-version: '8.3'
extensions: mbstring, ctype, phalcon-5.23.0

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to add the version in a env variable

zip
# Dev/test extensions
install-php-extensions \
phalcon-5.23.0 \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@Jeckerson
Jeckerson merged commit ea9a6c5 into 1.0.x Nov 1, 2026
25 of 26 checks passed
@Jeckerson
Jeckerson deleted the move-out-re2c branch November 1, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants