feat(php-cli): add support for -i and -v flags#1686
Closed
alexandre-daubois wants to merge 1 commit intophp:mainfrom
Closed
feat(php-cli): add support for -i and -v flags#1686alexandre-daubois wants to merge 1 commit intophp:mainfrom
-i and -v flags#1686alexandre-daubois wants to merge 1 commit intophp:mainfrom
Conversation
6ecd323 to
4adc99e
Compare
-i and -v flags when using php-cli-i and -v flags
Member
Author
|
@withinboredom Kevin told me that you may have start some work in php-src to mutualize some code between SAPIs? |
Member
|
For the record, I was refering to this: #1632 (comment) |
Member
|
@alexandre-daubois indeed! I will have a PR in the next week or so. I'm working on it alongside a branch of frankenphp that uses it to make sure it gives us what we need. I'll share that in the next couple of days if everything continues to go well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May fix #702
Proposing this draft for review to validate the approach mentioned in the issue's comment: #702 (comment)