Repository navigation
fix: compile generated extensions with GCC 14+, pass CI on Ubuntu 26.04 - #2834
Conversation
|
Does GitHub offer operating system runners than Ubuntu? I'd rather just run the san tests on an OS that gets proper bug fixes pulled in instead of whatever silly thing Canonical is doing. |
|
Ubuntu is what a big chunk of end users use so it makes sense to keep it, don't you think? |
|
🫣 |
|
I guess we can leave it for this backwards OS, but perhaps with a note. I'm generally not terribly happy with the changes here, they feel a bit misplaced in frankenphp. For enchant we should just wait for upstream fix (it's a bugfix so will go into 8.4+), and for running san tests I would prefer running them on new versions of software (e.g. gcc 16, clang 23). |
|
PR updated: the sanitizer jobs now use clang 22, which Ubuntu 26.04 has in its archive, instead of skipping the AVX-512 code. And a note next to the enchant line says when to drop it. Waiting for the php-src fix alone would keep every PR red for weeks, and 8.2/8.3 won't get it while we test them. The rest is ours: the generator emits C that GCC 14+ refuses. |
Generated extensions now define _GNU_SOURCE, and pass nullable int and bool arguments as pointers to values of the types cgo declares. On CI, the PHP of the Tests jobs no longer loads enchant (php/php-src#25412), and the sanitizers use clang 22.
4b69a15 to
a8b667c
Compare
|
Thank you @henderkes, comments addressed and PR squashed. |
Signed-off-by: Marc <m@pyc.ac>
Signed-off-by: Marc <m@pyc.ac>
ubuntu-latestis now Ubuntu 26.04, where nine jobs fail on every PR (see the checks of #2833):<stdlib.h>beforephp.h, so they now define_GNU_SOURCEascgo.godoes, and nullableintandboolarguments point to values of the types cgo declares.phpinfo()of the process: PHP unloads shared extensions when it shuts down, and libenchant 2.8 can't be loaded twice, GObject still knows its types. The PHP of the CI jobs no longer loads enchant._mm512_permutex2var_epi8()for uninitialized memory (fixed in clang 22 by [msan] Fix 'Simplify 'maskedCheckAVXIndexShadow' #147839' llvm/llvm-project#148785). The sanitizer jobs now use clang 22, which Ubuntu 26.04 has in its archive.The enchant abort is not only a CI matter: on such a system, a server dies at the first use of enchant after a worker restart, an
opcache_reset()or a config reload. SettingZEND_DONT_UNLOAD_MODULESfrom FrankenPHP avoids it, and #2730 too, but I left that out: net-snmp doesn't expect to be initialized twice, it floods the log at each start and the suite segfaults on the runner.