Repository navigation
feat: log when an opcache restart is done - #2844
Draft
nicolas-grekas wants to merge 2 commits into
Draft
nicolas-grekas wants to merge 2 commits into
nicolas-grekas wants to merge 2 commits into
Conversation
A worker uses opcache's shared memory for as long as its script runs. A restart of that memory reuses memory the worker still references. Once opcache waits for the threads of the process (php/php-src#24276), the restart never runs while workers are alive.
With php/php-src#23828, opcache calls a hook once a restart is done. Log it with how long caching was off. The worker scripts that started while the restart was pending start again right away, instead of after their next request.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2843, review the last commit.
php/php-src#23828 adds a hook that opcache calls once a restart is done. On PHP 8.7, FrankenPHP now logs it with how long caching was off:
The same signal wakes up the worker scripts that started while the restart was pending. They start again right away instead of after their next request.
Draft until php/php-src#23828 is merged. The version check assumes it's merged in 8.7.