Repository navigation
Conversation
Girgias
force-pushed
the
fibers-use-only-fcc
branch
from
October 1, 2026 12:26
ddc92ef to
4068a14
Compare
Girgias
force-pushed
the
fibers-use-only-fcc
branch
from
November 5, 2026 13:17
4068a14 to
d590a77
Compare
Member
Author
|
@arnaud-lb could you have a look as to why |
This reduces the size of the zend_fiber struct from 328 bytes to 280 while also simplifying memory management for callables, as this is all handled by the FCC API.
Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com>
Girgias
force-pushed
the
fibers-use-only-fcc
branch
from
November 16, 2026 15:39
d590a77 to
b3f2c3e
Compare
Girgias
marked this pull request as ready for review
November 16, 2026 16:07
Girgias
requested review from
DanielEScherzer,
arnaud-lb and
dstogov
as code owners
November 16, 2026 16:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the size of the zend_fiber struct from 328 bytes to 280 while also simplifying memory management for callables, as this is all handled by the FCC API.
I wonder if we should try to move the
zend_fiber_statusfield from_zend_fiber_contextto_zend_fiberbecause if we use a C23 enum it would fit in the gap between theflagsandparam_countfields.