Skip to content

Guard unknown internal calls in tracing JIT - #24700

Open
kairosci wants to merge 1 commit into
php:PHP-8.5from
kairosci:fix/gh-24286-jit-internal-call
Open

kairosci wants to merge 1 commit into
php:PHP-8.5from
kairosci:fix/gh-24286-jit-internal-call

Conversation

@kairosci

Copy link
Copy Markdown
Contributor

Fixes #24286 using @ndossche's callee-type guard, with regression tests. OPcache validation passes on debug ZTS and optimized NTS builds.

@kairosci
kairosci requested a review from dstogov as a code owner October 25, 2026 19:57
@kairosci
kairosci force-pushed the fix/gh-24286-jit-internal-call branch from ae20d29 to ab6e4fb Compare October 25, 2026 20:10
@ndossche
ndossche requested a review from arnaud-lb October 25, 2026 20:54
@ndossche

Copy link
Copy Markdown
Member

In my patch I posted I also added comments to explain the reasoning, I think they should be kept, since you copy it anyway you should copy the comments too.

@kairosci

Copy link
Copy Markdown
Contributor Author

Added!

@kairosci
kairosci force-pushed the fix/gh-24286-jit-internal-call branch 2 times, most recently from 4270fd5 to ec720cd Compare November 1, 2026 13:27
@kairosci
kairosci requested a review from derickr as a code owner November 1, 2026 13:27
@kairosci
kairosci force-pushed the fix/gh-24286-jit-internal-call branch 2 times, most recently from f71c410 to 971fbef Compare November 2, 2026 21:18
@kairosci
kairosci force-pushed the fix/gh-24286-jit-internal-call branch 3 times, most recently from f4c72ff to 85e1eb3 Compare November 16, 2026 17:48
@kairosci kairosci changed the title Fix GH-24286: Guard unknown internal calls in tracing JIT Guard unknown internal calls in tracing JIT Nov 16, 2026
Fixes php#24286.

Co-authored-by: Nora Dossche <7771979+ndossche@users.noreply.github.com>
@kairosci
kairosci force-pushed the fix/gh-24286-jit-internal-call branch from 85e1eb3 to 4fedf32 Compare November 16, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants