Repository navigation
Conversation
…or document init failure lxb_dom_document_init() set owner_document only after all of the document's memory pools were created. When one of these allocations failed, which the fallible lexbor allocators make possible once memory_limit is reached, the error path of lxb_html_document_interface_create() called lxb_dom_document_destroy() with a NULL owner_document and dereferenced it. lexbor/lexbor@e651d6b Only the source/lexbor part of the upstream change is carried.
kocsismate
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…document init failure
lxb_dom_document_init() set owner_document only after all of the document's memory pools were created. When one of these allocations failed, which the fallible lexbor allocators make possible once memory_limit is reached, the error path of
lxb_html_document_interface_create() called lxb_dom_document_destroy() with a NULL owner_document and dereferenced it. The failure path also left dangling pointers to the destroyed pools.
Set owner_document before allocating and reset the pool pointers on failure, carried as a lexbor patch until lexbor/lexbor#448 is merged. Only the source/lexbor part of the upstream change is carried.