Skip to content

Avoid clobbering bound spill slots - #25339

Draft
kairosci wants to merge 1 commit into
php:masterfrom
kairosci:fix/gh-25169-bound-slot-clobber
Draft

kairosci wants to merge 1 commit into
php:masterfrom
kairosci:fix/gh-25169-bound-slot-clobber

Conversation

@kairosci

@kairosci kairosci commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #25169 by syncing the bound spill slot fix from dstogov/ir#313.

@jorgsowa jorgsowa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong fix. Please verify in git history how the changes to bundled IR had been done in the past. The proper fix is not even merged yet in the upstream repository dstogov/ir#313

@kairosci
kairosci marked this pull request as draft November 9, 2026 14:10
@kairosci

kairosci commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

My mistake; I hadn't realized bundled IR changes on master must come through updating .github/scripts/download-bundled/jit-ir.sh after being merged upstream in dstogov/ir.

I've converted this PR to draft for now while waiting for dstogov/ir#313 to be reviewed and merged upstream. Once that lands, I will update the bundled revision via jit-ir.sh alongside the tests.

@kairosci
kairosci force-pushed the fix/gh-25169-bound-slot-clobber branch 3 times, most recently from e410136 to 2085e2c Compare November 16, 2026 17:48
@kairosci kairosci changed the title Fix GH-25169: avoid clobbering bound spill slots Avoid clobbering bound spill slots Nov 16, 2026
@kairosci
kairosci force-pushed the fix/gh-25169-bound-slot-clobber branch from 2085e2c to e1e05f1 Compare November 16, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function JIT: after $prev = $x; $x -= $step; an internal call makes $prev read the new $x (int|float $step, x86-64 Linux)

2 participants