Skip to content

coverage: exclude zend_parse_parameters_debug_error() - #25454

Draft
Girgias wants to merge 1 commit into
php:masterfrom
Girgias:2026-11-gcov-exclude-debug-function
Draft

Girgias wants to merge 1 commit into
php:masterfrom
Girgias:2026-11-gcov-exclude-debug-function

Conversation

@Girgias

@Girgias Girgias commented Nov 14, 2026

Copy link
Copy Markdown
Member

As it is a debug function that should never get triggered in production

As it is a debug function that should never get triggered in production

@iluuu1994 iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention to skip the function body itself, or also ignore calls to the function? Does this take care of both?

Comment thread gcovr.cfg
exclude-lines-by-pattern = \s*zend_dump_op_array\(.*\);\s*

# These functions are test/debugging functions
exclude-function = zend_parse_parameters_debug_error No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Missing final newline.

@Girgias

Girgias commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

Is the intention to skip the function body itself, or also ignore calls to the function? Does this take care of both?

I only thought about skipping the function body itself, didn't think about ignoring calls to the function, and that I don't this is covered, so probably an extra exclude-lines-by-pattern config is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants