Repository navigation
Fix use-after-free when a destructor changes the ArrayObject backing store - #25470
Closed
nicolas-grekas wants to merge 1 commit into
Closed
nicolas-grekas wants to merge 1 commit into
nicolas-grekas wants to merge 1 commit into
Conversation
…store spl_array_write_dimension_ex() replaces an existing value with zend_hash_update_ind() or zend_hash_index_update(), which destroy the previous value before storing the new one. Its destructor can append to the ArrayObject, which reallocates the table, or call exchangeArray(), which frees it. The new value is then written to freed memory. Store the new value first, then destroy the previous one.
Contributor
Author
|
/cc @arnaud-lb could you please have a look? |
Contributor
Author
|
Let me close: this needs a global fix, see #20001. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$ao['a'] = $valuedestroys the previous value before storing the new one. The destructor of the previous value can append to the ArrayObject, which reallocates the table, or callexchangeArray(), which frees it. The new value is then written to freed memory:This PR stores the new value first and destroys the previous one after, like for plain arrays.