Repository navigation
Fix opcache.enable_file_override lookups racing with OPcache restarts - #25483
Merged
Merged
Conversation
With opcache.enable_file_override=1, file_exists(), is_file() and is_readable() look the file up in the shared hash table first. The lookup neither checked whether the cache is enabled for the request nor took the SHM read lock, so it could run while a restart (scheduled by OOM, hash overflow or opcache_reset(), then executed by another process or thread) cleaned the hash and the scripts, and dereference freed entries. Look the hash up only when the cache is enabled for the request and the read lock is held, like accelerator_get_scripts() does; otherwise fall back to the original function.
* PHP-8.4: Fix phpGH-8739: OPcache restart corrupts SHM in threaded SAPIs (php#24276)
arnaud-lb
added a commit
that referenced
this pull request
Nov 16, 2026
* PHP-8.6: Fix opcache.enable_file_override lookups racing with OPcache restarts (#25483)
Member
|
Thank you! |
TimWolla
pushed a commit
to TimWolla/php-src
that referenced
this pull request
Nov 16, 2026
* PHP-8.4: Fix opcache.enable_file_override lookups racing with OPcache restarts (php#25483)
TimWolla
pushed a commit
to TimWolla/php-src
that referenced
this pull request
Nov 16, 2026
* PHP-8.5: Fix opcache.enable_file_override lookups racing with OPcache restarts (php#25483)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepared with an AI assistant (Claude), which also ran the reproduction and the tests on my machine; I reviewed the result. The text below is AI-generated (quoted, as asked in CONTRIBUTING.md).
🤖 Generated with Claude Code