fix(CLI): cache ignored when using --parallel with phrase pull#1085
Open
Thibaut Etienne (tetienne) wants to merge 6 commits intophrase:mainfrom
Open
fix(CLI): cache ignored when using --parallel with phrase pull#1085Thibaut Etienne (tetienne) wants to merge 6 commits intophrase:mainfrom
Thibaut Etienne (tetienne) wants to merge 6 commits intophrase:mainfrom
Conversation
Restore ctx.Err() check in PullParallel goroutines to respect context cancellation after first failure. Make copyToDestination fail explicitly on nil file instead of silently creating empty files. Remove dead 304 check after rate-limit retry. Simplify pull dispatch by replacing pullFn type with if/else. Add mutex to Save() and json:"-" to mu field for defensive thread safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When splitting the work between #1066 (--cache) and #1067 (--parallel), I forgot to thread the cache through the parallel code path. As a result,
--cache --parallelsilently ignored the cache: no conditional headers were sent, no ETags were stored, and every run re-downloaded all locale files.Tested against a production project with 204 locale files:
Test plan
go buildcompilesphrase pull --cache --parallelsecond run returns 304 for all filesphrase pull --parallelwithout--cachebehaves identically to beforephrase pull --cachewithout--parallelunaffected