feat(CLI): Support locale_mapping on push #SCD-863#1088
Open
feat(CLI): Support locale_mapping on push #SCD-863#1088
Conversation
jablan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for using locale_mapping during phrase push, enabling users to keep local locale identifiers in filenames while still uploading to the correct remote locales.
Changes:
- Introduces shared helpers to apply locale mapping (remote → local) and reverse mapping (local → remote).
- Applies reverse locale mapping during push locale-file discovery.
- Adds a comprehensive CLI integration spec suite for
push, including a newlocale_mappingscenario.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| clients/cli/spec/push_spec.rb | Adds integration specs covering push behavior, including locale_mapping. |
| clients/cli/cmd/internal/shared.go | Adds mapping helper functions used by pull/push placeholder handling. |
| clients/cli/cmd/internal/push.go | Applies reverse locale mapping when building locale files for push. |
| clients/cli/cmd/internal/push_source.go | Plumbs LocaleMapping into sources and applies reverse mapping to locale fields. |
| clients/cli/cmd/internal/pull_target.go | Switches pull placeholder replacement to use the new shared mapping helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply locale_mapping (custom named locales interpolated using
<locale_name>in the file names) also on push.