Skip to content

Support editor discovery in ~/Applications on macOS#2722

Open
amah853 wants to merge 2 commits into
pingdotgg:mainfrom
amah853:main
Open

Support editor discovery in ~/Applications on macOS#2722
amah853 wants to merge 2 commits into
pingdotgg:mainfrom
amah853:main

Conversation

@amah853
Copy link
Copy Markdown

@amah853 amah853 commented May 15, 2026

  • Resolve editors from user or system Applications on macOS when the CLI is missing
  • Add coverage for available-editor detection and launch path resolution

What Changed

The IDE Open button now also checks ~/Applications on macOS (not just /Applications) when looking for installed IDE apps.

If the editor’s CLI command isn’t on PATH, it can still show up as available if the .app bundle exists, and we launch it using open -a.

I also added tests to cover:

  • detecting an editor installed in ~/Applications
  • launching via open -a when the CLI isn’t available

Why

A lot of people install apps like Cursor / Zed into their user ~/Applications instead of the global /Applications.

Before this, the app could say “no installed editors found” (or only show editors installed in the global /Applications) even though the IDE is clearly installed. This makes the Open button feel broken for normal setups.

This keeps behavior predictable:

use CLI if it exists (best experience, supports --goto, etc.)
otherwise fall back to the macOS app bundle (still opens the right folder/file)

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Changes editor discovery and launch behavior on macOS by falling back from CLI commands to .app bundle detection and open -a, which could affect which editors are listed/used when multiple installs exist. Scope is limited to external launcher logic with added test coverage.

Overview
Improves macOS editor integration by discovering .app bundles in ~/Applications (and /Applications) when an editor’s CLI command is missing, so editors can still appear as available.

Updates resolveEditorLaunch to fall back to open -a <App.app> on darwin and strips any :line:column suffix for app-bundle launches. Adds tests covering user-Applications discovery, HOME-missing behavior, and the new launch fallback path.

Reviewed by Cursor Bugbot for commit 1954320. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Support editor discovery in ~/Applications on macOS

  • Adds resolveMacApplicationDirectories and resolveMacEditorApplication to locate .app bundles under ~/Applications and /Applications when no CLI is on PATH.
  • On darwin, resolveAvailableEditors now considers an editor available if its .app bundle exists, even without a CLI.
  • On darwin, resolveEditorLaunch invokes open -a <AppPath> <filePath> when a CLI is missing but the .app bundle is found.
  • Behavioral Change: when launching via macOS app bundle, line/column position arguments are stripped — only the file path is passed.

Macroscope summarized 1954320.

- Resolve editors from user or system Applications on macOS when the CLI is missing
- Add coverage for available-editor detection and launch path resolution
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 352385a0-9c57-49e9-ba11-0ab9804dbcc0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels May 15, 2026
Comment thread apps/server/src/process/externalLauncher.ts Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbfbb23. Configure here.

Comment thread apps/server/src/process/externalLauncher.ts
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 15, 2026

Approvability

Verdict: Approved

This PR adds a well-scoped, low-risk feature for macOS editor discovery in ~/Applications. The changes are self-contained, additive (existing behavior preserved as fallback), and thoroughly tested.

You can customize Macroscope's approvability policy. Learn more.

- Search /Applications even when HOME is unset
- Export mac helper functions for direct test coverage
@amah853
Copy link
Copy Markdown
Author

amah853 commented May 15, 2026

Whoops! Sorry about that.

apps/server/src/process/externalLauncher.ts:138 now always includes /Applications, even when HOME is missing or blank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant