Repository navigation
Frame properties disappeared (possible regression) #52
Description
Activity
For some reason, avs_make_writable triggered bug: #49 (comment)
PR #53 should fix itReacted by realfinder@FranceBB you can test this build: assrender_bin_win.zip
@realfinder, can u also test this build with your tests?
can u also test this build with your tests?
seems ok with the old tests I have, also the frame properties copied now
@realfinder thanks, then better use avs_copy_video_frame + avs_make_writable
PR updatedThanks, yes, will check it tomorrow. And I have to re-check the makewritable problem since things must work with it (I did not check it more deeply yet, neither your recent fixes, I'm not near my PC)
@realfinder
https://drive.google.com/uc?id=1NotIP-9NGTwiguElDxyUS7yxQBam6jr9
Could you please check this version? Thanks.
I'm using a simple avs_make_writable, which - theoretically - must work.Could you please check this version?
with this script #49 (comment) seems work fine
edit: maybe it was avspmod display problem/settings in the first place?
Thanks for the fix guys and for reinstating avs_make_writable, I can confirm that version 0.37 fixes the issue and frame properties are now correctly preserved. :)
- added a commit that references this issue
on Apr 13, 2026
As per this forum post by FranceBB
https://forum.doom9.org/showthread.php?p=2027669#post2027669
the frame properties has been killed and are not getting passed over.
I think this commit, which replaced
make_writeablewith a manual frame copy, did it.716df2f
avs_make_writable(p->env, &src);makes a complete content copy if needed, and preserves frame properties of source.Unlike
dst = avs_new_video_frame_a(p->env, &p->vi, AVS_FRAME_ALIGN);Which kills them.
However
avs_new_video_frame_p_ahas a source frame property parameter, but since I don't know whyavs_make_writablewas replaced, I recommend it only if we really have to useavs_new_video_frame_xxconstruct.@seiya-git:
Why did you make manual copy, since make_writeable is doing exactly the same. I remember making a comment on it.