Repository navigation
Conversation
(cherry picked from commit c8481f9)
* simplify #pad() * simplify #join() (cherry picked from commit 89e984c)
(cherry picked from commit bcf99b4)
(cherry picked from commit 08e53bd)
…nstead of concatenation with empty string (cherry picked from commit 22cf5d7)
(cherry picked from commit 1ad1f02)
(cherry picked from commit a94f1f9)
(cherry picked from commit ee9e165)
(cherry picked from commit c106f44)
(cherry picked from commit efb28ca)
* use HexFormat instead of manual encoding to hex-string (cherry picked from commit 4e8d1bd)
Netty 3 (org.jboss.netty) classes are not on the classpath since the netty-4.2 migration, so the documented/default ssl pipeline entries silently fail with ClassNotFoundException (initChannel swallows Throwable and logs 'error adding ...'). (cherry picked from cleanup branch fix; affects the same files as the broken part of cleanup 2391329, but as upgrade/master already has the wrong prefixes too)
Cherry-picks of mechanical commits (a94f1f9, 22cf5d7) carried over a partial createCountQuery rewrite that used strip() instead of trim(): strip() also trims unicode whitespace chars recognised by str.strip() (see py doc / \u001c-\u001f and NBSP), so count queries starting with those would behave differently than on master. Keep query.trim() to preserve the original behaviour, and in extractProp use String.valueOf(...).toLowerCase() instead of Character.toLowerCase so the lowercasing path stays identical to the old String.toLowerCase() behaviour (Character.toLowerCase is not equivalent for some chars, e.g. U+0130).
Remove play.server.FlashPolicyHandler: Adobe Flash is dead (https://www.adobe.com/products/flashplayer/end-of-life-alternative.html). It is dropped from the default play.netty.pipeline and play.ssl.netty.pipeline strings and from the commented examples in application.conf skeletons. Note: flash policy requests will no longer be answered; users relying on it must add their own handler to play.netty.pipeline. (cherry picked from commit 2391329; ssl pipeline string kept on io.netty - the cherry-pick carried the broken org.jboss.netty prefix from [cleanup], which would have re-introduced the regression from CLEANUP_BRANCH_REVIEW.md §2)
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a mechanical code cleanup of the framework core. It contains no changes
to public API signatures and no behavior changes, with one deliberate functional removal
(cross-domain policy handler).