Repository navigation
fix(mcp): keep MCP server credentials out of responses and workspace files - #547
Draft
FelipeRamos-neuro wants to merge 2 commits into
Draft
FelipeRamos-neuro wants to merge 2 commits into
FelipeRamos-neuro wants to merge 2 commits into
Conversation
A key stored in config.json was sent to the browser in clear text and filled a plain input. The capabilities response now carries a mask in its place (model lists, stored chat_model and inline_completion_model entries, claude_settings and acp_settings), ConfigHandler maps a posted mask back to the stored key, and the key inputs are password fields. LLMProviderProperty gains an opt-in `secret` flag. Closes plmbr#542
…files The Claude-mode server list masks every env and headers value. The NBI MCP editor masks credential-named values in the temp copy it writes to the workspace and restores them on save; a mask with nothing stored behind it is refused with a 400. Closes plmbr#543
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOKEN,SECRET,PASSWORD,API_KEY,KEY,PASSand similar, case-insensitive with-read as_.argsandurlare not masked..potgains one string.Evidence
Authorizationand*_TOKENvalues.********. The masked document round-trips to the original, an edited value replaces the stored one, and a renamed server's mask is refused.pytest tests/2531 passed,i18n checkand Prettier clean.Merge Danger
Door: two-way
The editor shows
********for credential-named values. A user who saves a different value types it over the mask.Blast Radius: MCP settings tabs and the MCP config file API
Closes #543