Repository navigation
Conversation
…ration
The registration module statically imported the svelte runtime
(import { mount } from "svelte") and @plone/registry, even though the
.svelte apps themselves are already loaded through dynamic imports. That
pulled the whole runtime (~110KB min) into the eager patterns chunk, loaded
on every page whether or not a content browser is on it.
Move the svelte import into the dynamic-import path already present in
init(), next to the existing await import("./src/App.svelte"), and the
@plone/registry import into register_default_components().
Same as for pat-contentbrowser: the registration module statically imported
the svelte runtime, putting it in the eager patterns chunk on every page.
Move the import into the dynamic-import path already present in init(),
next to the existing await import("./src/App.svelte").
…ved target When a JS framework host unmounts the content browser after a selection, the Svelte app kept running and writing selection state into an input that had already been removed. - destroy() now unmounts the Svelte app (so its reactive effects stop) and removes the browser node - setNodeValue() bails out when the target input node is gone
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.