Skip to content

Update dependencies + don't need corepack - #1656

Open
thet wants to merge 6 commits into
masterfrom
thet/update
Open

thet wants to merge 6 commits into
masterfrom
thet/update

Conversation

@thet

@thet thet commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

@petschki @MrTango @erral I'd like to switch away from corepack because corepack is installing it's managed depenencies globally. That puzzled me, when I wanted to use pnpm elsewhere and it was on version 10 instead of what I expected to be version 12.

Is that move OK for everyone? I don't really understand the advantages of corepack over npx pnpm, so if there is a drawback, let me know.

  • maint(Makefile): Use pnpm unlink recursive intead of defining potential linked repositories.

  • maint(Makefile): Use npx instead of corepack.

    • corepack is installing it's managed dependencies globally. With npx,
      we keep the dependencies locally.
    • pnpm uses the pinned version from packageManager from the second
      run on, once npx has downloaded the initial version.
    • We now can use pnpm self-update to update the packageManager
      version pin.
  • maint: Update pnpm to 12.6.0.

  • maint: Update dependencies.

  • maint: Update CI dependencies.

- corepack is installing it's managed dependencies globally. With npx,
  we keep the dependencies locally.

- pnpm uses the pinned version from ``packageManager`` from the second
  run on, once npx has downloaded the initial version.

- We now can use `pnpm self-update` to update the ``packageManager``
  version pin.
@petschki

petschki commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

If I understood the concepts correctly corepack helps collaborative teams to use the exact same package manager for their projects whereas npx is just a runner for packages which I do not want to be installed globally.

So if npx pins pnpm also to the packageManager version defined in package.json then I'm ok with that.

But since corepack is the recommended prerequisite in plone installations anyways (regarding the docs) I'd rather keep it.

@thet
thet requested review from MrTango, erral and petschki September 28, 2026 17:22
@thet

thet commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

current versions of pnpm up/downgrade the version to what packageManager has defined. Also, Node 25 doesn't ship with corepack anymore (which doesn't affect us, as we're installing it explicitly).

But for me, that corepack is installing it's managed tools globally is quite a no-go. I want my global node (resp - the node fnm or nvm are using for that current project) clean and without any tools I didn't explicitly installed there.

So I'm 👍 removing corepack 🙃

However, I can also remove that one commit from this PR and I need to remember that I never run make install in Mockup.

@thet thet mentioned this pull request Sep 28, 2026
@thet

thet commented Sep 28, 2026 •

Copy link
Copy Markdown
Member Author

There is a follow-up with less ambiguousness #1657

@petschki

Copy link
Copy Markdown
Member

Ok. I just read this one https://pnpm.io/package_json#devenginespackagemanager maybe we should move to this direction ... as long as its documented somewhere I'm now fine with removing corepack also 👍🏼

@erral

erral commented Sep 29, 2026

Copy link
Copy Markdown
Member

To tell the truth... I am completely lost on npm, yarn, pnpm, corepack etc.

@petschki

Copy link
Copy Markdown
Member

We should update the make targets accordingly to have a sane install/watch/build/serve experience regardless of the packagemanager and dependency madness.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants