Repository navigation
Conversation
|
@Hrittik20 thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Documentation build overview
|
stevepiercy
left a comment
There was a problem hiding this comment.
Bump one requirement (I maintain it).
|
Docs look great!
Let's make sure that the content for the request and response is correct. @plone/volto-team @plone/volto-developers @plone/aurora-developers would y'all please take a look and provide feedback? Thank you! |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
davisagli
left a comment
There was a problem hiding this comment.
The elegance of sphinxcontrib-httpexamples was that the example calls could be automatically generated from the actual HTTP messages. So it's unfortunate that this requires adding code in plone_client.py to match each request and generate the right @plone/client call. I realize that's necessary because the function names in @plone/client can't be automatically derived from the requests. However, I'm wondering: would it be possible to pass additional parameters to the http:example directive containing the information needed to write the @plone/client example? It would be easier to maintain if the information for an example is kept in one place rather than 2. (Well okay, it's already in multiple places, because we refer to separate files for the request and response. But I wonder if we can avoid adding another one. If not, I can live with it.)
|
@davisagli That makes sense. I looked into whether we could pass that info through the If that seems worth doing, I’m happy to help with a follow-up |
Summary
sphinxcontrib-httpexamplebuilder for@plone/clientCloses #2063
Notes for reviewers
@plone/clientAPI withawait(not TanStack hook names)deleteAliasesusespath: ''so the client calls/@aliasesplone/documentationwill be needed later so the tab also renders on 6.docs.plone.org after the submodule bumpcc @stevepiercy @sneridagh @pnicolli
Test plan
@plone/clienton the 6 mappable examples@plone/clienton POST/GET/PATCH/DELETEScreenshots