Skip to content

Don't use matplotlib internal API _major_tick_kw #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timhoffm wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Don't use matplotlib internal API _major_tick_kw #5598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plotly/matplotlylib/mplexporter/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ def get_text_style(text):
def get_axis_properties(axis):
"""Return the property dictionary for a matplotlib.Axis instance"""
props = {}
label1On = axis._major_tick_kw.get("label1On", True)
label1On = axis.get_tick_params().get("label1On", True)

if isinstance(axis, matplotlib.axis.XAxis):
if label1On:
Expand Down Expand Up @@ -257,7 +257,7 @@ def get_axis_properties(axis):

def get_grid_style(axis):
gridlines = axis.get_gridlines()
if axis._major_tick_kw["gridOn"] and len(gridlines) > 0:
if axis.get_tick_params()["gridOn"] and len(gridlines) > 0:
color = export_color(gridlines[0].get_color())
alpha = gridlines[0].get_alpha()
dasharray = get_dasharray(gridlines[0])
Expand Down