Repository navigation
Reject unevenly spaced x/y in create_streamline when steps shrink - #5797
Open
raashish1601 wants to merge 2 commits into
Open
raashish1601 wants to merge 2 commits into
raashish1601 wants to merge 2 commits into
Conversation
validate_streamline compared each step with the first one without taking the absolute value, so only steps larger than the first were caught and x such as [0, 2, 3, 3.5] passed as evenly spaced.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_streamlinedocuments thatxandymust be evenly spaced, andvalidate_streamlineis meant to check it. It compares each step with the first step withoutabs():so only steps larger than the first one are rejected. A grid whose steps shrink passes:
The streamline integration assumes a uniform grid (it uses
x[1] - x[0]and the index position), so such input silently produces misplaced streamlines. This addsabs()to both thexandychecks.Added
test_uneven_x_shrinking_stepsandtest_uneven_y_shrinking_stepsnext to the existingtest_uneven_x/test_uneven_y. They fail on main and pass with the change, and the rest ofTestStreamlinepasses.ruff format --check(0.11.12) is clean on the changed files.