Lining up strings with Core Plugwise, update translations#1048
Conversation
Keep some better string, add updates from #997
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughUpdated Plugwise integration localization across three JSON files: shortened and rephrased many user-facing strings, removed several obsolete error keys, added setup field help texts ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
custom_components/plugwise/strings.json (1)
1-357:⚠️ Potential issue | 🟡 MinorApply and commit Prettier’s JSON sorting/formatting output.
CI indicates this file is still being rewritten by the Prettier hook, so formatting/sorting changes were not fully committed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@custom_components/plugwise/strings.json` around lines 1 - 357, Prettier's JSON formatting/sorting wasn't applied to the strings JSON (keys like "config", "entity", "exceptions", "options", "services"); run your project's Prettier hook or execute prettier --write on the JSON file to remove trailing commas (e.g., after the "port" description), apply the canonical key ordering/sorting, and commit the updated strings.json so CI no longer rewrites it.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@custom_components/plugwise/strings.json`:
- Around line 25-26: The JSON has a trailing comma after the "port" entry in
strings.json which makes the file invalid; remove the comma following the "port"
value so the object closes correctly (i.e., ensure the "port" key/value pair
ends without a comma before the closing brace), then validate the file to
confirm well-formed JSON.
---
Outside diff comments:
In `@custom_components/plugwise/strings.json`:
- Around line 1-357: Prettier's JSON formatting/sorting wasn't applied to the
strings JSON (keys like "config", "entity", "exceptions", "options",
"services"); run your project's Prettier hook or execute prettier --write on the
JSON file to remove trailing commas (e.g., after the "port" description), apply
the canonical key ordering/sorting, and commit the updated strings.json so CI no
longer rewrites it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a6082cc8-2700-4c5a-a3ef-525761f3045f
📒 Files selected for processing (1)
custom_components/plugwise/strings.json
There was a problem hiding this comment.
Pull request overview
This PR updates the Plugwise integration’s strings.json to better align user-facing text (config flow labels/help text, error/abort messages, and a few entity/service labels) with the Home Assistant Core Plugwise phrasing and recent translation refinements mentioned in #997.
Changes:
- Standardizes several config-flow abort/error strings (e.g., authentication and XML/response errors).
- Adds help text (
data_description) for config/reconfigure fields (host/port/username/password). - Updates/extends a few UI labels (new climate state attribute label, boiler temperature label, options and service wording/capitalization).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hold translation file updates pending strings.json approval
bouwew
changed the title
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@custom_components/plugwise/translations/nl.json`:
- Line 38: The Dutch translation for the JSON key "password" is missing the
device name "Stretch"; update the value for the "password" entry in
custom_components/plugwise/translations/nl.json (the "password" JSON key) to
include "Stretch" so it mirrors the English phrasing (e.g., mention "Adam, P1,
Smile-T of Stretch") ensuring users of the Stretch device are not confused.
- Line 13: The translation value for the key "response_error" contains a typo
("ontvange"); update the string to "ongeldige XML-data of foutindicatie
ontvangen" by correcting the word to "ontvangen" so the Dutch message reads
correctly for the "response_error" entry.
- Around line 36-37: The translation entry under the "data_description" ->
"host" key uses inconsistent hyphenation ("IP adres"); update that string to use
"IP-adres" to match the other occurrences — locate the "data_description" object
and the "host" property in the nl.json translation and replace "IP adres" with
"IP-adres" so spelling is consistent across the file.
- Line 177: Update the nl.json translation value for the "name" entry currently
set to "Elektriciteitsconsumptie - cumulatief piek" to match the project's
formatting used elsewhere (no " - " dash and consistent word order). Replace the
value with a dash-free, consistent string such as "Elektriciteitsconsumptie piek
cumulatief" so it aligns with entries like "Elektriciteitsconsumptie laagtarief
cumulatief" and the English equivalent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ac8a29ed-ff7e-4230-99f5-1f703eb2cfd2
📒 Files selected for processing (2)
custom_components/plugwise/translations/en.jsoncustom_components/plugwise/translations/nl.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Keep some better strings, add updates from #997
Summary by CodeRabbit
Documentation
Style
Bug Fixes