fix: skip handling of SVG path elements with d attribute or inside svg#14
Open
Jungzl wants to merge 3 commits into
Open
fix: skip handling of SVG path elements with d attribute or inside svg#14Jungzl wants to merge 3 commits into
Jungzl wants to merge 3 commits into
Conversation
umar-ahmed
reviewed
May 14, 2026
Collaborator
umar-ahmed
left a comment
umar-ahmed
left a comment
There was a problem hiding this comment.
Nice catch! This is an edge case I hadn't come across yet.
Do you mind adding one more test case to test the case where there is no d attribute?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.