Skip to content

[removed] #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wongmjane wants to merge 2 commits into from
Closed

[removed] #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
397d056
fix: keep verification cache publication with its install owner
wongmjane Oct 2, 2026
8d622b3
test: include verification ownership in pull request checks
wongmjane Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/pr-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ jobs:
version: 11
run_install: true

- name: Test install and cache ownership
run: pnpm test

- name: Build dist/index.js
run: pnpm run build

Expand Down
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ the upload: pnpm refuses to run them unless the repository allow-lists the
package through `allowBuilds`, and a package on that list can already run code
in the job.

Only a successful action-owned install can publish that verdict. Its upload
window ends there even if another job already reserved the key, the upload
failed, or the log was rejected. The post step never retries that log after
later job steps have run. Skipped and failed installs do not publish it.

Before uploading, the action checks that the log grew the way an install grows
it: every record that predated the install still there, and no more new records
than installs it ran. A dependency's script that slips an extra record in is
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"build:bundle": "esbuild src/index.ts --bundle --platform=node --target=node24 --format=cjs --minify --outfile=dist/index.js",
"build": "pnpm run build:bundle",
"start": "pnpm run build && sh ./run.sh",
"test": "node --disable-warning=MODULE_TYPELESS_PACKAGE_JSON --experimental-strip-types --test src/cache-restore/*.test.mjs src/install-runtime/*.test.mjs src/pnpm-install/*.test.mjs src/pnpm-commands.test.mjs"
"test": "node --disable-warning=MODULE_TYPELESS_PACKAGE_JSON --experimental-strip-types --test src/cache-restore/*.test.mjs src/install-runtime/*.test.mjs src/pnpm-install/*.test.mjs src/lockfile-verification-cache/*.test.mjs src/pnpm-commands.test.mjs"
Comment thread
greptile-apps[bot] marked this conversation as resolved.
},
"dependencies": {
"@actions/cache": "^6.2.0",
Expand Down
Loading