Skip to content

Housekeeping: Update localstack-s3 image for functional tests#4437

Merged
CTMBNara merged 1 commit intomasterfrom
replace-s3-container
Mar 23, 2026
Merged

Housekeeping: Update localstack-s3 image for functional tests#4437
CTMBNara merged 1 commit intomasterfrom
replace-s3-container

Conversation

@osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented Mar 23, 2026

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added dependencies Pull requests that update a dependency file do not port labels Mar 23, 2026
Copy link
Collaborator

@Net-burst Net-burst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CTMBNara CTMBNara merged commit cfef0da into master Mar 23, 2026
6 of 7 checks passed
@CTMBNara CTMBNara deleted the replace-s3-container branch March 23, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file do not port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants