Repository navigation
Run the bump script with node so the automatic CLI release does not stop at pnpm's frozen install - #387
Merged
Conversation
… stop it pnpm 11 installs before running a script, and in CI that install is frozen. After the product pins change, the lockfile no longer matches, so `pnpm bump-version` failed before the script could refresh the lockfile. Running the script with node skips that check. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Caution Review failedThe pull request is closed. Summary by CodeRabbit
WalkthroughThe version-bump workflow now runs Severity of issue fixed: Low
|
commit: |
wmadden
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automatic CLI release for
@prisma/orm-toolchain8.0.0-rc.23 failed before it opened its pull request (run 42269193200). This change makes the "Bump the CLI version" step run the script with node:Why it failed
The step used to run
pnpm bump-version. pnpm 11 checks the install before it runs any script, and in CI that check is a frozen install. By that point the workflow has already written rc.23 into the manifests, so the lockfile (still rc.22) does not match and pnpm stops withERR_PNPM_OUTDATED_LOCKFILE. The script never ran, so it never got to refresh the lockfile itself.This started with #384, which replaced the old "Refresh the lockfile" step with
pnpm bump-version. Today's earlier composer run used the old step and passed.How I checked it
Locally on this branch, with
CI=true:node scripts/update-product-versions.mjs --channel releaserewrote@prisma/orm-toolchain8.0.0-rc.22 → 8.0.0-rc.23.pnpm bump-versionfailed with the samerunDepsStatusCheckerror as the CI run.node scripts/bump-version.tssucceeded: it bumped every package to 8.0.0-rc.32 and refreshedpnpm-lock.yamlto rc.23.pnpm install --frozen-lockfile --lockfile-onlythen passed.After this merges I will dispatch the workflow so it opens the rc.23 release pull request.
Alternatives considered
pnpm --config.verify-deps-before-run=false bump-version: works, but hides why in a config flag.pnpm install --lockfile-onlystep before the bump: refreshes the lockfile twice.Agent: bellatrix-52
🤖 Generated with Claude Code