Adjust for safe inset areas, plus other fixes#785
Merged
kevinaboos merged 3 commits intoproject-robius:mainfrom Mar 31, 2026
Merged
Adjust for safe inset areas, plus other fixes#785kevinaboos merged 3 commits intoproject-robius:mainfrom
kevinaboos merged 3 commits intoproject-robius:mainfrom
Conversation
Now that we have added support for safe inset areas into Makepad, we only want to draw a shadow *beneath* those two views, not all the way around. Previously the top part of the shadow was clipped by the native window bounds, but not any more.
Make SettingsScreen vertically y-scrollable only
Padding and spacing is now consistent because we added proper support for safe inset areas into Makepad itself. Show caption bar by default now. We can always hide it later. Re-fix logging in after token expiration, ensure that the LoginStatusModal doesn't repeatedly show itself, and that we don't get loads of disconnected errors after login has failed. (though we may have broken offline mode: logging in while disconnected) Fixed other misc things like alignment of SettingsScreen title.
kevinaboos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Padding and spacing is now consistent because we added proper support
for safe inset areas into Makepad itself.
Show caption bar by default now. We can always hide it later.
Re-fix logging in after token expiration, ensure that the LoginStatusModal
doesn't repeatedly show itself, and that we don't get loads of
disconnected errors after login has failed.
(though we may have broken offline mode: logging in while disconnected)
Fixed other misc things like alignment of SettingsScreen title.