Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several modifications and improvements to the modal analysis.
1.Internal force accuracy:
Added a new method to update internal node state for ChModalAssembly, named UpdateInternalStateWithStaticEquilibrium(too long... but I haven't thought of a shorter suitable function name yet), it solves the deformation of internal nodes by static equilibrium using m_solver_invKIIc. It works like a static correction, but doesn't change modal matrix. This function needs to be called manually now, only before retrieving internal loads. If this method proves stable for a time, Chrono's maintainers may consider merging it to UpdateInternalState.
Added a function for euler and timoshenko beam. These functions ensure that the beam's reference rotation follows the modal rotation, and are critical for accurate beam internal force results, especially for axial force of elements near boundary nodes. The core reason is that the current modal assembly is completely linear, and its deformation results are based on the undeformed system matrix, whereas the co-rotational coordinate system of the beam is nonlinear. Therefore, it is necessary to restore the co-rotational coordinate system to the undeformed state that follows the modal. Currently, these functions need to be called manually, which is not an ideal design, but at least does not affect other code, welcome any suggestions from the maintainers.
2.Numerical convergence
3.New modal demo about internal force
4.other issues
Welcome and appreciate any feedback. Best regards,