Add failing tests for issue #466: OAuth all-repo access by prompt-driven-github[bot] · Pull Request #467 · promptdriven/pdd

prompt-driven-github · 2026-02-04T20:27:14Z

Summary

Adds failing tests that detect the bug reported in #466 where PDD CLI requests access to ALL repositories instead of allowing selective repository access.

Test Files

Unit test: tests/test_get_jwt_token.py
E2E test: tests/test_e2e_issue_466_oauth_all_repo_scope.py

What This PR Contains

Unit tests that verify the OAuth scope "repo,user" is hardcoded at pdd/get_jwt_token.py:251
E2E tests that verify the complete authentication flow uses OAuth Apps which fundamentally cannot support selective repository access
Tests are verified to document the current buggy behavior

Root Cause

PDD CLI uses GitHub OAuth Apps with the repo,user scope, which by architectural design grants access to ALL repositories. This is a fundamental limitation of GitHub OAuth Apps that cannot be worked around by changing scopes. The repo OAuth scope always means "all repositories the user can access" - there is no OAuth scope that provides selective repository access.

Location: pdd/get_jwt_token.py:251 - The DeviceFlow class hardcodes scope = "repo,user"

Solution Required: Migrate from OAuth App to GitHub App for CLI authentication, which would allow users to install the app and select specific repositories during installation.

Test Behavior

These are regression tests that document the current buggy behavior:

Unit tests verify the hardcoded OAuth scope configuration
E2E tests verify the authentication flow behavior at the system level
After implementing the fix (migrating to GitHub Apps), these tests will need to be updated to verify the new selective access functionality

Next Steps

Implement the fix by migrating from OAuth App to GitHub App authentication
Update the tests to verify selective repository access works
Verify both unit and E2E tests pass with the fix
Run full test suite to check for regressions
Mark PR as ready for review

Fixes #466

Generated by PDD agentic bug workflow - Step 10

This commit adds comprehensive test coverage to detect the bug where PDD CLI requests access to ALL repositories instead of allowing selective repository access. Unit tests: - tests/test_get_jwt_token.py: Verify OAuth scope "repo,user" is hardcoded at pdd/get_jwt_token.py:251 E2E tests: - tests/test_e2e_issue_466_oauth_all_repo_scope.py: Verify the complete authentication flow uses OAuth Apps which cannot support selective repository access These are regression tests that document the current buggy behavior. After the fix (migrating to GitHub Apps), these tests will need to be updated to verify the new selective access functionality. Related to #466 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

prompt-driven-github · 2026-03-03T00:47:57Z

🚀 Job Queued!

Job ID: fRJdryZEkECkjijC5sia
Triggered by: @gltanaka
Label: sync

View Live Progress

prompt-driven-github · 2026-03-03T00:51:22Z

❌ PDD Execution Failed

Execution failed: PDD command failed with exit code 2.
Output: 2026-03-03 00:51:18,783 - pdd.llm_invoke - INFO - No local LLM model CSV found, will use package default
2026-03-03 00:51:18,793 - pdd.llm_invoke - INFO - LiteLLM disk cache configured at /opt/pdd-repo/pdd/litellm_cache.sqlite
Complete onboarding with pdd setup to install tab completion and configure API
keys.
Usage: pdd sync [OPTIONS] BASENAME
Try 'pdd sync --help' for help.

Error: No such option: --force

prompt-driven-github · 2026-03-03T01:01:41Z

🚀 Job Queued!

Job ID: pOdbRljzlqRphHW4KSpn
Triggered by: @gltanaka
Label: sync

View Live Progress

prompt-driven-github · 2026-03-03T01:04:02Z

❌ PDD Execution Failed

Execution failed: PDD command failed with exit code 2.
Output: on and configure API
keys.
Error during 'sync' command:
Usage Error: Basename '#467' contains
invalid characters. Only alphanumeric, underscore, hyphen, and forward slash
(for subdirectories) are allowed.
Usage: pdd sync [OPTIONS] BASENAME
Try 'pdd sync --help' for help.

Error: Basename '#467' contains invalid characters. Only alphanumeric, underscore, hyphen, and forward slash (for subdirectories) are allowed.

prompt-driven-github · 2026-03-03T01:29:41Z

🚀 Job Queued!

Job ID: XTVK0SmQvhj6Q0f6CORg
Triggered by: @gltanaka
Label: sync

View Live Progress

prompt-driven-github · 2026-03-03T01:38:01Z

❌ PDD Execution Failed

Execution failed: PDD command failed with exit code 1.
Output: architecture.json found, falling back to include-based dependency graph
Successfully loaded prompt: agentic_sync_identify_modules_LLM
Identifying modules to sync via LLM...
Status: Failed
Message: LLM identified no modules to sync
Cost: $0.6572
Model: anthropic
Error during 'unknown' command:
An unexpected error occurred: Command exited with code 1
📦 Debug snapshot saved to
/tmp/pdd_job_XTVK0SmQvhj6Q0f6CORg_a4ids431/.pdd/core_dumps/pdd-core-20260303T013
758Z.json (attach when reporting bugs)

prompt-driven-github · 2026-03-03T01:54:45Z

🚀 Job Queued!

Job ID: q17EalMpZVZLNXzVVlm3
Triggered by: @gltanaka
Label: sync

View Live Progress

prompt-driven-github · 2026-03-03T02:21:45Z

🚀 Job Queued!

Job ID: EOIxbczAb64D47qpZhJ4
Triggered by: @gltanaka
Label: sync

View Live Progress

prompt-driven-github · 2026-03-03T02:32:56Z

PDD Agentic Sync - Error

Dry-run validation failed:
get_jwt_token: LLM suggested cwd '.' but dry-run still failed: 2026-03-03 02:12:45,044 - pdd.llm_invoke - INFO - No local LLM model CSV found, will use package default
2026-03-03 02:12:45,052 - pdd.llm_invoke - INFO - LiteLLM disk cache configured at /opt/pdd-repo/pdd/litellm_cache.sqlite
Usage: pdd sync [OPTIONS] BASENAME
Try 'pdd sync --help' for help.

Error: No prompt files found for basename 'get_jwt_token' in directory '/tmp/pdd_job_q17EalMpZVZLNXzVVlm3_kt_hk2aa/prompts'.
Expected files with format: 'get_jwt_token_<language>.prompt'

test_get_jwt_token: LLM failed to suggest fix: All agent providers failed: google: Timeout expired
test_e2e_issue_466_oauth_all_repo_scope: LLM failed to suggest fix: All agent providers failed: google: Timeout expired

prompt-driven-github · 2026-03-03T02:34:45Z

❌ PDD Execution Failed

Execution failed: PDD command failed with exit code 1.
Output: architecture.json found, falling back to include-based dependency graph
Successfully loaded prompt: agentic_sync_identify_modules_LLM
Identifying modules to sync via LLM...
Status: Failed
Message: LLM identified no modules to sync
Cost: $0.7929
Model: anthropic
Error during 'unknown' command:
An unexpected error occurred: Command exited with code 1
📦 Debug snapshot saved to
/tmp/pdd_job_q17EalMpZVZLNXzVVlm3_kt_hk2aa/.pdd/core_dumps/pdd-core-20260303T023
442Z.json (attach when reporting bugs)

prompt-driven-github · 2026-03-03T04:06:57Z

❌ PDD Execution Failed

Execution failed: PDD command failed with exit code 1.
Output: 03-03 04:06:53,269 - pdd.llm_invoke - INFO - LiteLLM disk cache configured at /opt/pdd-repo/pdd/litellm_cache.sqlite
Fetching issue #467 from promptdriven/pdd...
Status: Failed
Message: Failed to fetch issue: gh: Bad credentials (HTTP 401)
Cost: $0.0000
Model:
Error during 'unknown' command:
An unexpected error occurred: Command exited with code 1
📦 Debug snapshot saved to
/tmp/pdd_job_EOIxbczAb64D47qpZhJ4_7tmnbs48/.pdd/core_dumps/pdd-core-20260303T040
653Z.json (attach when reporting bugs)

* test: Add failing tests for E2E timeout retry bug #791 - 8 unit tests in test_agentic_e2e_fix_orchestrator.py (2 pass prompt checks, 6 fail detecting missing behavior) - 3 E2E tests in test_e2e_issue_791_e2e_timeout_retry.py (all fail detecting the bug) - Prompt fix adding E2E pre-flight check and cross-cycle memory requirements Root causes: 1. No environment pre-flight check before Step 2 E2E tests (line 660-726) 2. step_outputs cleared between cycles destroying failure memory (line 857-859) Fixes #791 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: PDD bug changes for #791 * fix: pdd fix: E2E test step times out on every cycle, wasting cost and time Fixes #791 * fix: PDD fix changes for #791 * fix: persist skipped_steps to state and remove artifact files - Save skipped_steps in state_data so it survives resume across sessions - Load skipped_steps from state on resume (with JSON string-to-int key conversion) - Include skipped_steps in KeyboardInterrupt and Exception state saves - Remove artifact files: error_output_791.txt, test_errors_791.txt, and agentic_e2e_fix_orchestrator_test_agentic_e2e_fix_orchestrator_fixed.py Fixes #791 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add _check_e2e_environment mock to issue promptdriven#419 tests The new E2E environment preflight check skips Step 2 when no playwright config exists. Existing tests that expect Step 2 to dispatch to the LLM agent need to mock _check_e2e_environment to return (True, ""). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add _check_e2e_environment mock to issue promptdriven#545 tests Same fix as promptdriven#419 tests: mock the E2E environment preflight check so Step 2 dispatches to the LLM mock instead of being skipped. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add _check_e2e_environment mock to e2e_fix_deps fixture in promptdriven#549 tests Without this mock, _check_e2e_environment skips Step 2 (no playwright config in tmp_path), so the cycle1_step2 assertion fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: add _check_e2e_environment mock to promptdriven#468, promptdriven#467, promptdriven#357 test fixtures Same pattern as previous fixes — without this mock, _check_e2e_environment skips Step 2 (no playwright in tmp_path), breaking step execution assertions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address PR review — narrow skip trigger to timeouts, remove last_completed_step advance, add check=True - Narrow Step 2 skip to timeout-specific errors only (not transient provider outages like rate limits) - Remove contradictory last_completed_step = step_num in skip path (skipped_steps dict already handles cross-cycle memory) - Add check=True to git subprocess calls in test_issue_791 fixture Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: PDD Bot <pdd-bot@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Greg Tanaka <glt@alumni.caltech.edu>

prompt-driven-github bot mentioned this pull request Feb 4, 2026

pdd cli cloud requests access to ALL repos instead of selective #466

Open

gltanaka added pdd-sync PDD: sync prompts with code and removed pdd-sync PDD: sync prompts with code labels Mar 3, 2026

prompt-driven-github bot self-assigned this Mar 3, 2026

gltanaka added pdd-sync PDD: sync prompts with code and removed pdd-sync PDD: sync prompts with code labels Mar 3, 2026

prompt-driven-github bot mentioned this pull request Mar 11, 2026

pdd fix: workflow retries deterministically failed steps across cycles, wasting cost and time #661

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add failing tests for issue #466: OAuth all-repo access#467

Add failing tests for issue #466: OAuth all-repo access#467
prompt-driven-github[bot] wants to merge 1 commit intomainfrom
fix/issue-466

prompt-driven-github bot commented Feb 4, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

prompt-driven-github bot commented Feb 4, 2026

Summary

Test Files

What This PR Contains

Root Cause

Test Behavior

Next Steps

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

❌ PDD Execution Failed

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

❌ PDD Execution Failed

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

❌ PDD Execution Failed

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

PDD Agentic Sync - Error

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

❌ PDD Execution Failed

Uh oh!

prompt-driven-github bot commented Mar 3, 2026

❌ PDD Execution Failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants