Cleanup module port and parameter lists#311
Merged
Merged
Conversation
colluca
force-pushed
the
interface-cleanup
branch
from
0c23baa to
0dddb5a
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This includes: - Module parameter port lists (parameters and dependent localparams) - Module body localparams derived from module parameters - All instantiation sites using named parameter binding - Comments and string literals that referenced old names - Both RTL source modules and testbench modules Hardcoded architectural constants (e.g. WIDTH = 16 in cc_exp_backoff) that do not depend on any module parameter are left in ALL_CAPS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rename every parameter type declaration that did not follow the *_t naming convention: T → data_t (all CDC, stream, spill-register, read modules) dtype → data_t (cc_fifo, cc_shift_register, cc_shift_register_gated) type_t → data_t (cc_stream_fifo_optimal_wrap, cc_passthrough_stream_fifo) DataType → data_t (cc_rr_arb_tree) DATA_T → data_t (cc_stream_mux, cc_stream_arbiter, cc_stream_arbiter_flushable) Parameters already following the convention (addr_t, idx_t, rule_t, data_t, payload_t, mem_req_t, mem_resp_t, …) are left untouched. All instantiation sites using named parameter binding (.T, .dtype, …) and all internal body uses (port declarations, signal types, type casts) are updated consistently. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The ARBITER parameter in cc_stream_arbiter and cc_stream_arbiter_flushable
previously used ad-hoc string values ("rr", "prio") to select the
arbitration scheme. Replace it with an enum defined in cc_pkg.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
phsauter
force-pushed
the
interface-cleanup
branch
from
0dddb5a to
df3323b
Compare
This was referenced Jun 3, 2026
Open
phsauter
approved these changes
Jun 3, 2026
Collaborator
phsauter
left a comment
phsauter
left a comment
There was a problem hiding this comment.
This took a while to get through but it looks good, I don't think any bug was introduced or something was missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only stylistic changes in this one, mostly aligned with the LowRisc style guide.
_i/_osuffixes to all module portsT,dtype,type_t,DataType,DATA_Tare all converted todata_t)cc_pkg.svTODO