hw: fix double bw vlsu#100
Open
Navaneeth-KunhiPurayil wants to merge 9 commits into
Open
Conversation
Navaneeth-KunhiPurayil
force-pushed
the
fix/vle
branch
from
0880bcc to
4092e56
Compare
Navaneeth-KunhiPurayil
force-pushed
the
fix/vle
branch
from
813b565 to
83426d6
Compare
DiyouS
reviewed
Jun 3, 2026
Collaborator
DiyouS
left a comment
DiyouS
left a comment
There was a problem hiding this comment.
Hi Navaneeth, in general looks good to me. But there are some small details can be improved.
| if (sb_enable_o[port]) begin | ||
| // VFU and VSLDU: intID derived from vl_cnt progress, vl_cnt updated every successful write | ||
| if (port inside {SB_VFU_VD_WD, SB_VSLDU_VD_WD}) begin | ||
| automatic logic intID = (vl_cnt_q[sb_id_i[port]] < vl_max_d[sb_id_i[port]]) ? 0 : 1; |
Collaborator
There was a problem hiding this comment.
Might be better to avoid using automatic for debugging purposes
|
|
||
| #include "vector_macros.h" | ||
|
|
||
| int8_t mask[1] = {0xAA}; |
Collaborator
There was a problem hiding this comment.
will this data be stored on address 0x0? Might be better to add attribute here. I saw these issues in cache-version, and cause illegal visits to DRAMSys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Added
vlse