Merged
Conversation
Member
laminne
commented
May 4, 2026
laminne
commented
- 固定値を入れるようにしました
- デモ環境の設定が上書きされる問題を解消しています
MikuroXina
requested changes
May 5, 2026
Contributor
MikuroXina
left a comment
MikuroXina
left a comment
There was a problem hiding this comment.
CI 落ちてます. デプロイ用の環境として別の env に分けてこれらの vars を定義したほうがよいかと思います.
MikuroXina
requested changes
May 5, 2026
Contributor
MikuroXina
left a comment
MikuroXina
left a comment
There was a problem hiding this comment.
env というのはこれのことです: https://developers.cloudflare.com/workers/wrangler/environments/
環境変数を CI から書き込んで制御する必要はないかと思います.
Member
Author
|
Cloudflareのダッシュボードからデプロイコマンドを変更できるのでそれでいけそうでした |
MikuroXina
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.