Fix SV-WOHL verification artifact ID collision#16
Merged
Conversation
artifacts/verification/SV-WOHL-001.yaml was a bundle declaring five sw-verification artifacts as SV-WOHL-001..005. But SV-WOHL-002.yaml ..008.yaml are separate sys-verification artifacts — IDs 002..005 were declared twice by two different artifact families (a software- requirement verification and a system verification colliding on the same ID). rivet 0.12.0 flags duplicate IDs as errors (rivet 0.10.0, which the repo's CI runs had been using until the unpinned rivel-cli rebuilt to a newer version, did not) — so CI now fails on this pre-existing bug. Fix (architect's call): re-prefix by verification kind. - sys-verification artifacts keep SV-WOHL-* (SV = System Verification). - The five sw-verification artifacts move to SWV-WOHL-001..005, one file each, matching the one-artifact-per-file convention of the rest of artifacts/verification/. The SV-WOHL-001.yaml bundle is removed. No cross-references needed updating — nothing links to these IDs; their `verifies` links point outward to SWREQ-* (unchanged). rivet validate (0.12.0): PASS, 0 errors. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
artifacts/verification/SV-WOHL-001.yamlwas a bundle declaring fivesw-verificationartifacts asSV-WOHL-001..005. ButSV-WOHL-002.yaml…008.yamlare separatesys-verificationartifacts. IDsSV-WOHL-002..005were each declared twice — by two unrelated artifact families colliding on the same ID range.rivet validate(v0.12.0) reports these as 4 errors. Earlier wohl CI runs usedrivetv0.10.0, which did not flag duplicate IDs — CI rebuildsrivet-clifrom the unpinnedrivetsibling each run, and the tool got stricter. The bug itself is pre-existing; it was just invisible until the tool caught up.Fix
Re-prefix by verification kind (architect's decision):
sys-verificationartifacts keepSV-WOHL-*(SV = System Verification).sw-verificationartifacts move toSWV-WOHL-001..005, one file each — matching the one-artifact-per-file convention of the rest ofartifacts/verification/. TheSV-WOHL-001.yamlbundle is removed.No cross-references needed updating — nothing links to these IDs; their
verifieslinks point outward toSWREQ-*(unchanged).Verification
rivet validate(v0.12.0, same as CI): PASS, 0 errors (down from 4 errors). Remaining warnings are the pre-existing lifecycle-coverage notes shared by every approved requirement.Related
rivetadvanced. Pinningrivet/relayto commit SHAs (per CI follow-ups: matrix split, pinned siblings, cargo-deny, bazel build, nightly long-fuzz #8) would make the gate deterministic.rivet-validatefailure was caused entirely by this pre-existing collision, not by its own changes.🤖 Generated with Claude Code