Bring workspace to clippy-clean + fmt-clean baseline

[avrabe]

Summary

Mechanical, semantics-preserving cleanup of the wohl workspace so a future cargo fmt --check + cargo clippy -D warnings CI merge gate can land cleanly. No behavior changes; all 92 tests pass, Kani verified on all 6 components (20 harnesses total).

This is PR 1a of 2 for the foundation work — PR 1b (#TBD) will introduce the CI workflow itself, README, and CLAUDE.md drift fix. Issue #1 is closed by PR 1b, not this one.

⚠ Merge order: PR #4 (sync of unpushed local-main commits) must merge first. Independent reviewers flagged that this PR's diff currently bundles those 5 commits because origin/main was 5 commits behind local main. After PR #4 merges, this PR's diff will auto-shrink to the three commits actually authored here (3f2f524 cleanup + d06c553 reasons + 5a44e87 reason-pointer fix).

What changed

Workspace lints (modern Rust check-cfg idiom):

• Root Cargo.toml: [workspace.lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(kani)'] }
• Each of the 8 crates: [lints] workspace = true
• Eliminates 6× "unexpected cfg(kani)" warnings without scattering #[allow] attributes

Clippy fixes (all 6 monitor crates):

Lint	Count	Crates
missing Default impl	6	all monitors
x = x + 1 → +=	9	leak, temp, alert
manual abs-diff → .abs_diff()	1	power
index-loop → .iter().enumerate()	1	air
collapsible nested if	3	door (×2), hub (×1)

wohl-hub dead-code (judgment-based, with load-bearing reason = "..." per architect review):

• #[allow(dead_code, reason = "...")] on 5 TOML config structs and ALERT_HEALTH_MISS — reasons connect each suppression to specific follow-up work (Track D Verus, scheduler thread at spar/wohl_system.aadl:207, TOML schema surface)
• #[cfg(test)] on config_from_str (only called from tests)
• Deleted contact_zone method — truly unused, no callers anywhere

Format sweep:

• cargo fmt --all reformatted 8 files with pre-existing drift (engine.rs files + wohl-hub/main.rs)
• wohl-integration/src/lib.rs was incidentally swept as well

Verification

Check	Result	Verified by
cargo fmt --all --check	clean	author
cargo clippy --workspace --all-targets -- -D warnings	clean	author
cargo test --workspace --all-features	92 passed, 0 failed	author
cargo kani -p wohl-leak	4/4 verified	author
cargo kani -p wohl-temp	3/3 verified	independent reviewer
cargo kani -p wohl-air	3/3 verified	independent reviewer
cargo kani -p wohl-door	3/3 verified	independent reviewer
cargo kani -p wohl-power	3/3 verified	author
cargo kani -p wohl-alert	4/4 verified	independent reviewer

All 20 Kani harnesses across 6 monitors PASS post-cleanup. Verification status preserved.

Reviewer feedback addressed

• Architect (round 1): added reason = "..." to every #[allow(dead_code)] directive (commit d06c553)
• Architect (round 2): corrected a file pointer (wohl_firmware.aadl → wohl_system.aadl:207) in the SchedulerConfig reason (commit 5a44e87)
• Tester + Architect (blocking, round 1): undeclared scope from 5 prior commits in the PR diff — resolved by opening PR Sync: wohl-hub CCSDS support and AADL system models #4 as a separate sync; this PR's diff will be just 3f2f524 + d06c553 + 5a44e87 once PR Sync: wohl-hub CCSDS support and AADL system models #4 merges
• Both reviewers (round 2): approve, conditional on PR Sync: wohl-hub CCSDS support and AADL system models #4 merging first

Out of scope

• CI workflow / README / CLAUDE.md drift fix — PR 1b (next)
• Verus proofs for wohl-alert dedup invariant — separate Track D work
• Sibling relay/* clippy drift — visible as warnings from dependencies but not gated by this workspace's lints
• Cargo.lock change reflects relay sibling now depending on relay-primitives and adding relay-ccsds — upstream, not authored here

Test plan

• cargo fmt --all --check (local, macOS-aarch64)
• cargo clippy --workspace --all-targets -- -D warnings (local)
• cargo test --workspace --all-features (local, 92 pass)
• cargo kani -p wohl-{leak,power} (local, 4/4 + 3/3 PASS)
• cargo kani -p wohl-{temp,air,door,alert} (independent reviewer verified — 3/3 + 3/3 + 3/3 + 4/4 PASS)
• Reviewer-flagged dead-code judgment calls audited (contact_zone deletion confirmed safe; config_from_str use confirmed test-only; ALERT_HEALTH_MISS retention confirmed ID-numbering-preserving)

🤖 Generated with Claude Code