Repository navigation
Accept ReadError from a read pending during ASGI WebSocket close - #1354
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_read_during_and_after_closefails on anyio 4.16.0, as reported in #1309.Since anyio 4.16.0, closing a memory stream wakes a pending
receive()withClosedResourceErrorinstead ofEndOfStream. A read that is pending whenaclose()runs now raiseshttpcore2.ReadErrorinstead of returningb"".Both outcomes are valid, so only the test changes:
AsyncWebSocketSessionhandlesReadErrorand EOF in the sameexceptclause.ReadErrorwhen a read is interrupted by a local close.The test now accepts either outcome for the pending read. It still requires
ReadErrorfor a read started after close.Checklist
Session:
pi --session 01a1e9c9-f8a7-747b-8fb8-baaed8bd78de