Repository navigation
[Bugfix] End the call when its status can't be sent - #145
Merged
Merged
Conversation
A handler that set details or trailing metadata the front can't take left the call open until the client's deadline. server() also takes bytes details and None trailing metadata, as grpc.server() does. Signed-off-by: MinJun Choi <mj04300017@gmail.com>
Signed-off-by: MinJun Choi <mj04300017@gmail.com>
Perf: server cost per callHead
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #139
A handler that set details or trailing metadata the front can't take left the call open, so the client waited until its deadline.
_answer()now ends the call withINTERNALon any exception and logs it. If the front already ended the call, this does nothing.server()also takes whatgrpc.server()takes here: bytes inset_details()andabort(), andNoneinset_trailing_metadata().aio.server()ends a call with bytes details withINTERNAL, sincegrpc.aiorefuses them.How it was tested:
server()andaio.server()with bad details and trailing metadata on unary and stream calls. They fail without this change.set_details()with bytes andset_trailing_metadata(None)matchgrpc.server()onserver().Special notes for your reviewers:
Bad input still gets a different status from grpcio in some cases. For example,
abort(code, 5)ends withINTERNALhere and keepscodeongrpc.server(). The call ends either way, so I left those alone.If applicable: