Repository navigation
[Test] Run the interop cases over TLS and check handshakes with OpenSSL - #148
Merged
Merged
Conversation
Signed-off-by: MinJun Choi <mj04300017@gmail.com>
Signed-off-by: MinJun Choi <mj04300017@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #147
interop/run.pynow runs every case with and without TLS, so the job goes from 112 runs to 224. The Go and Python clients connect to127.0.0.1and verify the certificate aslocalhost. The summary shows one table for each.tests/test_tls.pygets handshake tests that connect with Python'sssl. They cover TLS 1.2 and 1.3, a client that doesn't offerh2, and required client certificates on TLS 1.2. Both grpcio and pygrpc-native have to give the same result.The job now also fails when
empty_unaryfails on grpcio. Before, a client that couldn't connect failed on both servers, and that counted as no difference.How it was tested:
All 224 interop runs pass, and so does
pytest tests.tests/test_tls.pyalso passes on Python 3.10 with grpcio 1.64.3, and on 3.13.To check the tests can fail, I broke
src/server/tls.rsthree ways:Pointing the clients at the wrong CA fails the job too.
Special notes for your reviewers:
Most of the
interop/run.pydiff is indentation from the new loop.A client that offers no ALPN isn't tested on purpose, because the two servers differ there: see #146.
If applicable: