Skip to content

Melting: Edit CNA descriptor functions#636

Open
prabhath-c wants to merge 2 commits intoprabhath_melting_stackedfrom
melting_cna
Open

Melting: Edit CNA descriptor functions#636
prabhath-c wants to merge 2 commits intoprabhath_melting_stackedfrom
melting_cna

Conversation

@prabhath-c
Copy link
Copy Markdown
Contributor

No description provided.

@prabhath-c prabhath-c requested a review from jan-janssen as a code owner March 15, 2026 22:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d172caf8-3eba-4f89-8a25-272254cc54e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch melting_cna
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@prabhath-c prabhath-c changed the title Edit CNA descriptor functions Edit CNA descriptor functions for melting Mar 15, 2026
@prabhath-c prabhath-c changed the title Edit CNA descriptor functions for melting Mleting: Edit CNA descriptor functions Mar 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (prabhath_melting_stacked@396d06c). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             prabhath_melting_stacked     #636   +/-   ##
===========================================================
  Coverage                            ?   86.92%           
===========================================================
  Files                               ?       44           
  Lines                               ?     2501           
  Branches                            ?        0           
===========================================================
  Hits                                ?     2174           
  Misses                              ?      327           
  Partials                            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prabhath-c prabhath-c changed the title Mleting: Edit CNA descriptor functions Melting: Edit CNA descriptor functions Mar 15, 2026
Comment on lines -44 to -52
structure (pyiron_atomistics.structure.atoms.Atoms): The structure to analyze.
mode ("total"/"numeric"/"str"): Controls the style and level
of detail of the output.
- total : return number of atoms belonging to each structure
- numeric : return a per atom list of numbers- 0 for unknown,
1 fcc, 2 hcp, 3 bcc and 4 icosa
- str : return a per atom string of sructures
diamond (bool): Flag to either use the diamond structure detector or
the common neighbor analysis.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this more detailed docstring removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants