Repository navigation
Preserve literal inline comment markers in parsed values - #84
Closed
sricharanreddycheruku wants to merge 1 commit into
Closed
sricharanreddycheruku wants to merge 1 commit into
sricharanreddycheruku wants to merge 1 commit into
Conversation
Member
|
closing due to ai violation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IniConfig.parse()currently truncates values at any#or;, including URL fragments and semicolon-separated text. For example,http://example.org/#fragmentbecomeshttp://example.org/. Continuation lines have the same problem.Only recognize an inline comment when its marker is preceded by whitespace, as proposed in #83. Inspect values before stripping leading whitespace so
key=#literalstays literal whilekey= #commentis still an empty value. Apply the same rule to continuation lines and document it in the parsing API and README.Addresses the inline-comment bug in #83. The malformed section header and broader compatibility-policy questions remain open.
Validation on Linux, Python 3.12:
git diff --checkpasses.The existing constructor and
strip_inline_comments=Falsebehavior are preserved. Section header comment handling is unchanged.